Repository navigation
smartplaylist: accept library for relative_to - #7175
Open
kayleeCromwell wants to merge 4 commits into
Open
kayleeCromwell wants to merge 4 commits into
kayleeCromwell wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7175 +/- ##
==========================================
+ Coverage 80.82% 80.85% +0.02%
==========================================
Files 150 150
Lines 21209 21212 +3
Branches 3239 3240 +1
==========================================
+ Hits 17143 17150 +7
Misses 3248 3248
+ Partials 818 814 -4
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5348.
proposed solution: The playlist plugin accepts library for relative_to however smartplaylist treated every value as a path. Setting relative_to: library made paths relative to a folder named library in the current directory, rather than to the music library. This makes smartplaylist accept library for both the relative_to option and the relative-to flag. Paths are then made relative to the library directory, so the two plugins can be used together without a hardcoded path.
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)