Skip to content

smartplaylist: accept library for relative_to - #7175

Open
kayleeCromwell wants to merge 4 commits into
beetbox:masterfrom
kayleeCromwell:smartplaylist-relative-to-library
Open

kayleeCromwell wants to merge 4 commits into
beetbox:masterfrom
kayleeCromwell:smartplaylist-relative-to-library

Conversation

@kayleeCromwell

Copy link
Copy Markdown

Description

Fixes #5348.
proposed solution: The playlist plugin accepts library for relative_to however smartplaylist treated every value as a path. Setting relative_to: library made paths relative to a folder named library in the current directory, rather than to the music library. This makes smartplaylist accept library for both the relative_to option and the relative-to flag. Paths are then made relative to the library directory, so the two plugins can be used together without a hardcoded path.

To Do

  • [ x] Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • [x ] Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • [ x] Tests. (Very much encouraged but not strictly required.)

@kayleeCromwell
kayleeCromwell requested a review from a team as a code owner November 11, 2026 19:39
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (e170aee) to head (876e2d6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7175      +/-   ##
==========================================
+ Coverage   80.82%   80.85%   +0.02%     
==========================================
  Files         150      150              
  Lines       21209    21212       +3     
  Branches     3239     3240       +1     
==========================================
+ Hits        17143    17150       +7     
  Misses       3248     3248              
+ Partials      818      814       -4     
Files with missing lines Coverage Δ
beetsplug/smartplaylist.py 91.34% <100.00%> (+2.74%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match smartplaylist options with playlist plugin

1 participant