http3: use the configured dialer and connection settings - #1
Closed
iFixRobots wants to merge 1 commit into
Closed
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer needed for Instagram: the captured native TLS fingerprint works over HTTP/2 with the existing req/uTLS transport. Meta imroc#361 and SDK #4992 have removed this dependency.
Beeper's SDK supplies its own network dialer, but req doesn't use it for HTTP/3. This lets Instagram use req's existing HTTP/3 transport through the SDK and removes the separate QUIC adapter from the bridge.
Validated in Beeper on the Pixel: Instagram's native push registration returned 200 over HTTP/3 using this commit and the SDK dialer. Android and iOS builds passed.
Related: mautrix/meta#361