Repository navigation
Use UTF-8 for expected ledger fixtures - #218
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expected ledger fixtures now use UTF-8 for generation and comparison. With a GBK default, the previous writer produced bytes that UTF-8 readers could not decode, and the reader corrupted valid UTF-8 text before comparing it. Fixes #194.
The change adds
encoding="utf-8"to the two existing file opens. Current Beancount requires UTF-8 ledger input; the tests verify these fixtures with Beancount 2.x and 3.x.Evidence
Merge danger
Reversible. Affects expected fixture generation and comparison. Existing non-UTF-8 expected files containing locale-encoded text must be converted or regenerated as UTF-8; comparison may otherwise raise
UnicodeDecodeError.Unverified
An actual Windows GBK system locale, Python 3.7, remaining CI runtime/dependency combinations and upstream CI. The full Windows suite retains the same 16 failed nodes before and after, with 143 passing tests becoming 145 and three skips.