Fix bzl_library reordering#627
Open
keith wants to merge 1 commit into
Open
Conversation
Previously depending on other context in the BUILD file this gazelle plugin would move bzl_library targets even if they didn't change at all.
keith
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
tetromino
requested changes
Jun 23, 2026
tetromino
left a comment
tetromino
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for taking a look at this! The existing logic was obviously wrong in multiple ways.
However, for your proposed change, I don't understand why the canonical name matters: if all of a bzl_library's sources files have been deleted, shouldn't we delete the bzl_library target regardless of what it is named?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously depending on other context in the BUILD file this gazelle
plugin would move bzl_library targets even if they didn't change at all.