Extend Kuka .rsix and .xml with more GPIOs#13
Conversation
destogl
left a comment
There was a problem hiding this comment.
Please check if the mapping is correct.
| </RsiObject> | ||
| <RsiObject ObjTypeId="14" ObjType="Map2DigOut" ObjId="Map2DigOut_46"> | ||
| <Inputs> | ||
| <Input InIdx="0" OutObjId="Ethernet_1" OutIdx="19" /> |
There was a problem hiding this comment.
Here is the last index 19, but below 20. Is this correct.
There was a problem hiding this comment.
There seems to be an offset of 1 between INDX in the eth.xml and OutIdx in the .rsix. That is the case also in the example GPIO.
This pattern is applied for Map2DigOut_1:
Following the same pattern, we end up with indexes up to 18 in .rsix and 19 in eth.xml (after removing the example gpio).
| <ELEMENT TAG="GPIO.01" TYPE="BOOL" INDX="8" HOLDON="1" /> | ||
| <ELEMENT TAG="GPIO.01" TYPE="BOOL" INDX="8" HOLDON="1" /> | ||
| <!-- Ejectors (suction) --> | ||
| <ELEMENT TAG="GPIO.suction_1" TYPE="BOOL" INDX="9" HOLDON="1" /> |
There was a problem hiding this comment.
Above seems to me to be 8 starting index, but here is 9? Correct?
There was a problem hiding this comment.
Thank you for identifying this error. This is because we kept the example GPIO. The commit 343659e removes it so the starting index is 8 again.
| @@ -8,6 +8,14 @@ | |||
| <Inputs> | |||
| <Input InIdx="0" OutObjId="DigOut_1" OutIdx="0" /> | |||
There was a problem hiding this comment.
why do we have here DigOut? Is this an error.
There was a problem hiding this comment.
I would even remove the examples.
| <Input InIdx="6" OutObjId="DigIn_136" OutIdx="0" /> | ||
| <Input InIdx="7" OutObjId="DigIn_137" OutIdx="0" /> | ||
| <Input InIdx="8" OutObjId="DigIn_138" OutIdx="0" /> | ||
| <Input InIdx="9" OutObjId="DigIn_139" OutIdx="0" /> |
There was a problem hiding this comment.
here you end with 9 and below with 10.
There was a problem hiding this comment.
| <ELEMENT TAG="GPIO.extend_check_2" TYPE="BOOL" INDX="7" /> | ||
| <ELEMENT TAG="GPIO.extend_check_4" TYPE="BOOL" INDX="8" /> | ||
| <ELEMENT TAG="GPIO.retract_check_2" TYPE="BOOL" INDX="9" /> | ||
| <ELEMENT TAG="GPIO.retract_check_4" TYPE="BOOL" INDX="10" /> |
There was a problem hiding this comment.
here you end up with index 10, not sure if this maps correctly.
| </BlueprintCollections> | ||
| <Constructs xmlns="RsiConstruct"> | ||
| <Construct Name="Ethernet_1" BlueprintName="Ethernet" BlueprintCollection="RSI" Location="400,370"> | ||
| <Inputs> |
| <DoubleParameter Name="MaxE6" CanBeSetFromKrl="true" Value="2000" /> | ||
| </Parameters> | ||
| </Construct> | ||
| <Construct Name="DigOut_1" BlueprintName="DigOut" BlueprintCollection="RSI" Location="0,370" /> |
There was a problem hiding this comment.
Also this. It is UI but still to be consistent
| <ELEMENT TAG="AK.A5" TYPE="DOUBLE" INDX="6" HOLDON="1" /> | ||
| <ELEMENT TAG="AK.A6" TYPE="DOUBLE" INDX="7" HOLDON="1" /> | ||
| <!-- Ejectors (suction) --> | ||
| <ELEMENT TAG="GPIO.suction_1" TYPE="BOOL" INDX="8" HOLDON="1" /> |
There was a problem hiding this comment.
But above those start at index 7, so the other file has to be adjusted
There was a problem hiding this comment.
Yes, but from what I have seen on the example file, there is an offset of 1 between the indexes in the .rsix and eth.xml as displayed with the example GPIO:
- Map2DigOut_1: OutIdx:7 (.rsix) --> INDX:8 (eth.xml).
The same pattern is followed by the other elements: - e.g: AK.A6: OutIdx:6 (.rsix) --> INDX:7 (.eth.xml)
I just want to confirm before making the change: shall we set the OutIdx to 8 in the .rsix file when mapping it to GPIO.suction_1? And change all indexes accordingly?
There was a problem hiding this comment.
Ah OK, you are right! Ok we try it like this on the robot.
Based on the branch
kuka-master-updates.The goal if the MR is to extend the GPIOs of the
b_ctrldbox_rsi.rsixandb_ctrldbox_rsi_eth.xmlto match the number of GPIOs defined in the AIP Project.In
b_ctrldbox_rsi.rsix, the DigIn and DigOut suffixes (e.g: DigIn_132 & DigIn_139) refer to the mappings defined inside the AIP Wiki.In
b_ctrldbox_rsi_eth.xml, the GPIO names match the ones defined for the state/command interfaces for the AIP Bosch Gripper.The example GPIOs
GPIO.01andGPIO.02were left untouched.