Unskip integ tests mlops#5887
Merged
Merged
Conversation
a27c58a to
590adba
Compare
590adba to
c91fc53
Compare
aviruthen
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
5 integ tests in
sagemaker-mlopswere conditionally skipped via@pytest.mark.skipifbecause they require SageMaker Spark container images, which only support Python 3.9 and 3.12. Since CI runs integ tests on Python 3.10, these tests were never executed.This PR introduces a
spark_py312marker to split mlops integ tests into two groups:spark_py312spark_py312marked tests (Spark/Feature Processor tests that depend on SageMaker Spark images)This allows both groups to run in CI without version conflicts. The corresponding buildspec change to add the py312 step will be done separately in the CI infra (SageMakerMLFPySDKInfraCDK).
Changes
spark_py312marker insagemaker-mlops/tox.ini@pytest.mark.skipifwith@pytest.mark.spark_py312on 4 tests intest_feature_processor_integ.py@pytest.mark.spark_py312to 1 test intest_feature_processor_spark_compat.pytest_to_pipeline_and_execute_with_lake_formationremains skipped (@pytest.mark.skip) due to unresolved Lake Formation environment configuration in CI (tracked separately)Testing
Validated via CodeBuild in Prod:
-m "not spark_py312": all tests pass, spark tests correctly excluded-m spark_py312: 4/5 tests pass, 1 skipped (Lake Formation)