feat: allow callers to specify custom IAM path for instance profiles#9120
Open
DerekFrank wants to merge 1 commit intoaws:mainfrom
Open
feat: allow callers to specify custom IAM path for instance profiles#9120DerekFrank wants to merge 1 commit intoaws:mainfrom
DerekFrank wants to merge 1 commit intoaws:mainfrom
Conversation
Contributor
|
Preview deployment ready! Preview URL: https://pr-9120.d18coufmbnnaag.amplifyapp.com Built from commit |
DerekFrank
force-pushed
the
instance-profile-sweeping
branch
3 times, most recently
from
eedc8e8 to
60a51c6
Compare
jigisha620
reviewed
Apr 30, 2026
Contributor
jigisha620
left a comment
jigisha620
left a comment
There was a problem hiding this comment.
ListClusterProfiles and ListNodeClassProfiles still use the old path so if the downstream consumers use a different path then the garbage collector will not be able to find orphaned profiles.
Change the Create() method signature from accepting a usePath bool
to accepting a path string. When non-empty, the path is set directly
on the CreateInstanceProfile input. This allows downstream consumers
(e.g. EKS Auto) to use a custom IAM path prefix like /eks/ instead
of the hardcoded /karpenter/ prefix.
The upstream karpenter-provider-aws caller now explicitly passes the
/karpenter/{region}/{clusterName}/{nodeClassUID}/ path string.
DerekFrank
force-pushed
the
instance-profile-sweeping
branch
from
60a51c6 to
4a61b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
instanceprofile.Provider.Create()to accept apath stringparameter instead ofusePath boolpathis non-empty, it is set directly on theCreateInstanceProfileinput, allowing downstream consumers to specify custom IAM path prefixes/karpenter/{region}/{clusterName}/{nodeClassUID}/path stringHow was this change tested?
make presubmitDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.