docs: support opmetrics/pmetrics metric constructors in metrics doc generator#9119
Open
DerekFrank wants to merge 1 commit intoaws:mainfrom
Open
docs: support opmetrics/pmetrics metric constructors in metrics doc generator#9119DerekFrank wants to merge 1 commit intoaws:mainfrom
DerekFrank wants to merge 1 commit intoaws:mainfrom
Conversation
2ababfc to
0378d87
Compare
0378d87 to
e5aa148
Compare
Contributor
|
Preview deployment ready! Preview URL: https://pr-9119.d18coufmbnnaag.amplifyapp.com Built from commit |
2df8925 to
0d3f52e
Compare
…ctors and regenerate all versioned metrics docs
0d3f52e to
37343ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
The metrics documentation generator only recognized prometheus.New*() calls for extracting metric declarations from source code. After the migration to operatorpkg's opmetrics.NewPrometheus*() and pmetrics.NewPrometheus*() wrappers, the generator silently dropped all karpenter core and provider-aws metrics, producing incomplete documentation.
Changes:
How was this change tested?
Updated the docs as evidence of success
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.