Skip to content

Scope test:unit to tests/unit and normalize placeholder scripts (Fixes #5643) - #5652

Closed
ssmurfgg04-gif wants to merge 9 commits into
aws-powertools:mainfrom
ssmurfgg04-gif:normalize-test-scripts
Closed

Scope test:unit to tests/unit and normalize placeholder scripts (Fixes #5643)#5652
ssmurfgg04-gif wants to merge 9 commits into
aws-powertools:mainfrom
ssmurfgg04-gif:normalize-test-scripts

Conversation

@ssmurfgg04-gif

Copy link
Copy Markdown

What

Following the plan in #5643:

  • test:unit is now vitest --run tests/unit in every package that had the bare vitest --run (commons, batch, jmespath, kafka, testing, validation), so a local npm run test:unit no longer pulls in the e2e suites that need AWS credentials.
  • Placeholder strings for test:e2e and test:unit:types are normalized to a single form, echo 'Not Implemented', across packages/*.
  • vitest run is normalized to vitest --run, and the test:unit:types flag order is unified to vitest --run tests/types --typecheck.

Why

As described in #5643: running unit tests locally in batch (and five other packages) executes the SQS e2e suite, which fails or hangs without AWS credentials. The placeholder drift also defeats grepping for which packages lack a suite.

Verification

  • Confirmed each touched package has a tests/unit directory, so the scoped path resolves.
  • Diff is scripts-only, package.json contents otherwise untouched.
  • I left CODING_STANDARDS.md alone to keep this reviewable; happy to add the canonical forms there in a follow-up if preferred.

Fixes #5643

@powertools-for-aws-oss-automation

Copy link
Copy Markdown

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template at .github/PULL_REQUEST_TEMPLATE.md#acknowledgment

@powertools-for-aws-oss-automation

Copy link
Copy Markdown

Your PR title does not follow the Conventional Commits rules for this repository.

Problem: The title cannot be parsed as a Conventional Commit.

Expected format: <type>[optional scope][optional !]: <description>

Allowed types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert, improv

Allowed scopes: tracer, logger, metrics, parameters, idempotency, data-masking, commons, parser, jmespath, event-handler, validation, batch, layers, ci, docs, tests, internal, maintenance, deps, deps-dev, roadmap, kafka, signer

Please update your PR title and the check will re-run automatically.

@svozza

svozza commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Please fix this PR to follow our repo conventions. There is a create-issue skill you can point your agent to that will do this.

@dreamorosi

Copy link
Copy Markdown
Contributor

Thank you for taking the time to contribute! We've decided to handle this one as maintainers since it touches conventions we're standardizing across the repo, and it's now addressed in #5653. Closing this in favor of that PR — we'd be happy to see you pick up another issue.

@dreamorosi dreamorosi closed this Sep 7, 2026
@ssmurfgg04-gif

Copy link
Copy Markdown
Author

Fair enough, repo conventions win. Thanks for folding it into #5653 and for the invite, I will go through the open issues and pick up another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR between 30-99 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: scope test:unit to tests/unit and normalise package scripts

3 participants