Scope test:unit to tests/unit and normalize placeholder scripts (Fixes #5643) - #5652
Scope test:unit to tests/unit and normalize placeholder scripts (Fixes #5643)#5652ssmurfgg04-gif wants to merge 9 commits into
Conversation
|
No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template at |
|
Your PR title does not follow the Conventional Commits rules for this repository. Problem: The title cannot be parsed as a Conventional Commit. Expected format: Allowed types: Allowed scopes: Please update your PR title and the check will re-run automatically. |
|
Please fix this PR to follow our repo conventions. There is a |
|
Thank you for taking the time to contribute! We've decided to handle this one as maintainers since it touches conventions we're standardizing across the repo, and it's now addressed in #5653. Closing this in favor of that PR — we'd be happy to see you pick up another issue. |
|
Fair enough, repo conventions win. Thanks for folding it into #5653 and for the invite, I will go through the open issues and pick up another one. |
What
Following the plan in #5643:
test:unitis nowvitest --run tests/unitin every package that had the barevitest --run(commons, batch, jmespath, kafka, testing, validation), so a localnpm run test:unitno longer pulls in the e2e suites that need AWS credentials.test:e2eandtest:unit:typesare normalized to a single form,echo 'Not Implemented', acrosspackages/*.vitest runis normalized tovitest --run, and thetest:unit:typesflag order is unified tovitest --run tests/types --typecheck.Why
As described in #5643: running unit tests locally in batch (and five other packages) executes the SQS e2e suite, which fails or hangs without AWS credentials. The placeholder drift also defeats grepping for which packages lack a suite.
Verification
tests/unitdirectory, so the scoped path resolves.CODING_STANDARDS.mdalone to keep this reviewable; happy to add the canonical forms there in a follow-up if preferred.Fixes #5643