[bb-async-job + 2 more] Route event-block resources to their resolved compute by Simone319 · Pull Request #459 · aws-devtools-labs/aws-blocks

Simone319 · 2026-08-31T21:41:32Z

Problem

Event Building Blocks (AsyncJob, CronJob, Realtime) wired their native AWS resources — SQS event source, EventBridge scheduler target, WebSocket integration — directly to the stack's shared Lambda handler. For multi-compute, each event block must instead target the compute that owns it, so its resources follow the resolved compute rather than assuming the single default handler.

Changes

AsyncJob (bb-async-job): attach the SQS event source to this.compute's function (guarded on LambdaCompute) instead of the shared handler; partial-batch-failure options preserved.
Synth guard (new, all three blocks): AsyncJob, CronJob, and Realtime each gain a LambdaCompute guard in this change (none had one before) that throws a typed UnsupportedCompute error on any other compute type — assertable via isBlocksError and covered by a throw-path test per block.
CronJob (bb-cron-job): resolve the scheduler target from this.compute.
Realtime (bb-realtime): wire the shared WebSocket infra from this.compute's function.
Each event block declares a @aws-blocks/bb-lambda-compute dependency and imports the CDK-typed LambdaCompute via its new /cdk subpath (no coupling to core internals).
No public { compute } option is added here — blocks reach this.compute, which resolves to the default compute for any current app. The customer-facing assignment surface is a later track.

Validation

CDK tests updated to the BlocksStack.create harness and assert the event source / target / integration lands on the resolved compute's function (default and ancestor-_compute cases).
Green locally: bb-async-job 77, bb-cron-job 29, bb-realtime 72, core 729; full build + lint pass.

Checklist

PR description included
Tests are changed or added
Relevant documentation is changed or added (changeset event-blocks-compute-targeting.md)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot · 2026-08-31T21:41:37Z

🦋 Changeset detected

Latest commit: 330acaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@aws-blocks/core	Minor
@aws-blocks/bb-async-job	Minor
@aws-blocks/bb-cron-job	Minor
@aws-blocks/bb-realtime	Minor
@aws-blocks/bb-lambda-compute	Minor
@aws-blocks/bb-agent	Patch
@aws-blocks/blocks	Minor
@aws-blocks/bb-logger	Patch
@aws-blocks/bb-kv-store	Patch
@aws-blocks/bb-distributed-table	Patch
@aws-blocks/auth-common	Patch
@aws-blocks/bb-app-setting	Patch
@aws-blocks/bb-data	Patch
@aws-blocks/bb-distributed-data	Patch
@aws-blocks/bb-auth-basic	Patch
@aws-blocks/bb-auth-cognito	Patch
@aws-blocks/bb-auth-oidc	Patch
@aws-blocks/bb-dashboard	Patch
@aws-blocks/bb-file-bucket	Patch
@aws-blocks/bb-knowledge-base	Patch
@aws-blocks/bb-email-client	Patch
@aws-blocks/bb-tracer	Patch
@aws-blocks/bb-metrics	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AsyncJob, CronJob, and Realtime attach their compute-bound resources to the compute resolved via `this.compute` instead of the stack's shared handler: - AsyncJob attaches its SQS event source to the compute's function; - CronJob points its EventBridge Scheduler target at the compute's function; - Realtime wires its shared WebSocket API integrations to the compute's function. All three require a LambdaCompute today and fail at synth with a clear error on any other compute type. On the default single-Lambda setup `this.compute` resolves to the stack's default compute (the shared handler), so this is non-breaking with no change to synthesized infrastructure. AsyncJob also grants SQS send to the shared execution role. bb-agent's CDK test moves onto the BlocksStack.create harness (which initializes the default compute the blocks now resolve). CronJob's CDK test keeps its synth-time schedule/timezone validation coverage alongside the compute-targeting coverage.

soberm

Code review — the compute-targeting refactor is sound (IAM swap is correct, ./cdk export is well-formed, no circular dependency, dependency placement is right). Most findings are posted inline. Two items that don't anchor to a changed line:

[LOW] Extraneous nested @aws-blocks/core@0.2.0 in package-lock.json (marked "extraneous": true, under bb-agent/node_modules/.../bb-lambda-compute/node_modules/@aws-blocks/core). Hygiene noise, but relevant to instanceof LambdaCompute: if a block ever resolves a different copy of bb-lambda-compute than the default-compute factory used, the guard misfires. ^0.3.0 is consistent across manifests so dedup should hold — please regenerate the lockfile cleanly to drop the extraneous entry.

[LOW] Test-only type assertions (e.g. _defaultCompute as LambdaCompute, defaultChild as cdk.CfnElement) brush against the AGENTS.md no-casts rule. They're narrowing casts (not as any) and test-only, so low severity — a small typed helper would keep them out of the assertion sites.

Minor nit on the PR description: it says AsyncJob "now guards this the same way CronJob and Realtime do" — the diff shows the guard added to all three simultaneously; CronJob/Realtime had no prior guard.

… sanitized key Address review on #459: - bb-async-job: sanitize the BLOCKS_HANDLER_OWNER_ config key identically to the adjacent QUEUE_URL key. Config entries are loaded into process.env at runtime (loadConfigToProcessEnv), so the key must be a valid env var name and the Phase-2 owner-match reader must reconstruct the same string byte-for-byte. - All three event blocks: throw a typed UnsupportedCompute error from the Lambda-compute guard (assertable via isBlocksError) instead of a bare Error, matching each block's existing synth-time error taxonomy. - Add throw-path tests for all three: construct a non-Lambda compute and assert the guard throws the typed error (the headline "fail loud at synth" behavior was previously uncovered). - Drop a stale extraneous @aws-blocks/core@0.2.0 entry from package-lock.json.

…gether

Simone319 · 2026-09-03T10:13:20Z

Thanks for the thorough pass, @soberm. Addressed the inline findings in f5ba09d; on the three summary items:

Extraneous nested @aws-blocks/core@0.2.0: removed in f5ba09d. It was a stale lockfile-only entry (no backing dir on disk, not required by the tree) that npm install / --package-lock-only wouldn't prune, so I dropped the block and re-validated with npm install --package-lock-only (npm did not re-add it). ^0.3.0 is consistent across manifests, so the dedup holds and the instanceof LambdaCompute guard resolves a single copy.
Test-only casts: leaving these. They are test-internal assertions (_defaultCompute is an internal field; CfnElement is CDK-tree introspection), not customer-facing API usage, so they fall under the test-plumbing exception to the no-casts rule rather than the customer-DX surface it protects. Happy to add a small typed helper if you feel strongly.
Description wording: the "matches the CronJob / Realtime guards" phrasing was in the AsyncJob code comment (the description didn't actually claim a prior guard); corrected it in 72cb60c, and made the PR description explicit that all three guards are added together in this change.

@sarayev

…ealtime shared-role publish Address @sarayev review on #459: - Replace `instanceof LambdaCompute` in all three event-block guards with `LambdaCompute.isLambdaCompute()`, backed by a `Symbol.for('blocks:LambdaCompute')` brand, so the check survives duplicate bb-lambda-compute copies in one tree (where `instanceof` misfires once versions diverge). - Add a single `blocksError(name, message)` to @aws-blocks/core (exported from every entry) and route all three guards through it; bb-async-job/errors.ts and bb-realtime/utils.ts re-export it instead of defining their own. - Add `sanitizeConfigKey(id)` to @aws-blocks/core/bb-utils; use it for both the QUEUE_URL and HANDLER_OWNER writers and the runtime reader so writer/reader can't drift. - Realtime: bind the shared WebSocket routes to the stack DEFAULT compute deterministically (new @internal Scope.defaultCompute) instead of the block's resolved compute, and grant postToConnection to the shared execution role so publish() works from any compute — removes the per-stack-singleton divergence. - Changeset bumped to minor for the added public surface (blocksError, sanitizeConfigKey, bb-lambda-compute ./cdk + isLambdaCompute, UnsupportedCompute members); regenerated core API report.

…rtCdkConditionActive)

…ort from bb-utils The config module owns the config-key contract, so the key-sanitization rule lives beside getConfigSync/loadConfigToProcessEnv. bb-utils re-exports it (pure aggregator pattern) so BB authors still import from @aws-blocks/core/bb-utils. No behavior or public-surface change.

Simone319 had a problem deploying to publish August 31, 2026 21:54 — with GitHub Actions Failure

Simone319 temporarily deployed to publish August 31, 2026 21:57 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish August 31, 2026 22:24 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 10:21 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 10:23 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 10:32 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 10:59 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 11:02 — with GitHub Actions Inactive

Simone319 temporarily deployed to publish September 1, 2026 11:55 — with GitHub Actions Inactive

Simone319 had a problem deploying to publish September 1, 2026 14:07 — with GitHub Actions Failure

Simone319 had a problem deploying to publish September 1, 2026 16:39 — with GitHub Actions Error

Simone319 had a problem deploying to publish September 1, 2026 16:42 — with GitHub Actions Error

This was referenced Sep 1, 2026

fix(hosting): drop CloudFront invalidation from BlocksConfigDeployment (aws-cdk#15891 CREATE timeout) #473

Closed

fix(ci): run E2E matrix when CI workflow definitions change #474

Open

Simone319 added 2 commits September 2, 2026 14:22

Merge branch 'main' into zimzha/multi-compute-c1-c3-event-blocks

05f791c

soberm reviewed Sep 3, 2026

View reviewed changes

Comment thread packages/bb-async-job/src/index.cdk.ts Outdated

Comment thread packages/bb-async-job/src/index.cdk.ts Outdated

Comment thread packages/bb-cron-job/src/index.cdk.ts Outdated

Comment thread packages/bb-realtime/src/index.cdk.ts Outdated

Simone319 added 2 commits September 3, 2026 12:11

docs(bb-async-job): clarify the guard is added to all three blocks to…

72cb60c

…gether

docs(api): regenerate API reports for UnsupportedCompute error additions

41ec7a1

soberm previously approved these changes Sep 3, 2026

View reviewed changes

sarayev reviewed Sep 3, 2026

View reviewed changes

Simone319 added 3 commits September 4, 2026 13:59

test(bb-async-job): comment why NODE_OPTIONS is set in before() (asse…

4d67ecf

…rtCdkConditionActive)

sarayev approved these changes Sep 4, 2026

View reviewed changes

soberm approved these changes Sep 4, 2026

View reviewed changes

This was referenced Sep 5, 2026

docs: clarify event block compute compatibility #494

Open

fix(bb-cron-job): grant scheduler role access to all computes #517

Open

Navigation Menu

[bb-async-job + 2 more] Route event-block resources to their resolved compute - #459

[bb-async-job + 2 more] Route event-block resources to their resolved compute#459
Simone319 merged 8 commits into
mainfrom
zimzha/multi-compute-c1-c3-event-blocks

Simone319 commented Aug 31, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 31, 2026 •

edited

Loading

Uh oh!

soberm left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simone319 commented Sep 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Simone319 commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Validation

Checklist

Uh oh!

changeset-bot Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

soberm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simone319 commented Sep 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Simone319 commented Aug 31, 2026 •

edited

Loading

changeset-bot Bot commented Aug 31, 2026 •

edited

Loading

soberm left a comment •

edited

Loading