Repository navigation
Add support for ResourcePolicy CRD - #76
Merged
ack-prow[bot] merged 15 commits intoAug 31, 2026
Merged
Conversation
- Add ResourcePolicy resource using PutResourcePolicy as Create operation - Use aws_service_sdk_version v1.65.0 which includes ResourceArn, RevisionId, PolicyScope, ExpectedRevisionId fields — no hook templates needed - Use is_iam_policy: true for PolicyDocument to support IAM semantic comparison (handles statement reordering, Action arrays vs strings, Principal variations) - Add custom update handler (customUpdateResourcePolicy) for ExpectedRevisionId on resource-scoped policies to prevent concurrent modification errors - Ignore ImportTask and ScheduledQuery resources added in v1.65.0 SDK - Add unit tests for IAMPolicyDocumentEqual delta behavior Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Generate sdkUpdate implemenation with template hook for populating ExpectedRevisionID
- When ResourceARN is set ensure that Resource policy scope is applied - Set ExpectedRevisionId when deleting resource scoped policies
knottnt
force-pushed
the
resource-policy
branch
from
August 18, 2026 23:02
2f39325 to
1b018bb
Compare
- Add hooks for create/update to use top level RevisionID when setting Status.RevisionID - Re-generate with forked code-generator
knottnt
commented
Aug 19, 2026
| # ResourceARN. PolicyName is designated the primary key so identifier code | ||
| # still generates, and is_primary_key_optional makes adoption populate | ||
| # whichever identifier fields the user supplies without requiring PolicyName. | ||
| is_primary_key_optional: true |
Contributor
Author
There was a problem hiding this comment.
- Add custom_check_required_fields_missing_method to fail sdkFind with NotFound if neither identifier is set. - Add e2e tests to validate missing adoption-fields scenario and validate positive cases for policyName and resourceARN
knottnt
added
the
release/minor
- Apply mutually_exclusive_identifiers config for PolicyName and ResourceArn - Add tests for PopulateResourceFromAnnotation and requiredFieldsMissingFromReadManyInput
Member
|
/LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavodiaz7722, knottnt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow Bot
pushed a commit
that referenced
this pull request
Aug 31, 2026
Fixes aws-controllers-k8s/community#2986 Releasing changes: * #76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Based off of #71 by @mahasiva-amazon with some additional fixes to prevent regressions in the LogGroup resource and leverage generated code in the update operation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.