Add Harness and HarnessEndpoint resources - #43
Conversation
|
Hi @rdoshi1. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
054be5a to
5f51b72
Compare
|
/test all |
| properties: | ||
| actorID: | ||
| type: string | ||
| arn: |
There was a problem hiding this comment.
It looks like this could reference a Memory CR. In order to support that I think we'll need to rename this field to something like memoryArn to give the code-generator a prefix it can append the "Ref" suffix to.
There was a problem hiding this comment.
I investigated this during regeneration. With code-generator v0.62.0, a nested field named only Arn cannot produce a stable Ref name because Arn is entirely an identifier suffix, and the generator has no nested-shape rename override. Direct ARN input remains supported, and I documented this limitation in the PR description. Would you prefer to defer this optional reference, or handle the needed nested rename support as a separate code-generator change?
There was a problem hiding this comment.
Hmm we do have an open code-generator PR to add nested rename support. Will see if we can get that merged in the near term.
There was a problem hiding this comment.
Given that code-generator #721 is still unapproved and has failing required checks, I propose deferring this optional Memory CR reference for this PR. Direct ARN input remains supported, and the minimal Harness use case does not require a Memory CR. If #721 lands before final regeneration, I can add the nested rename/reference then; otherwise this can follow separately.
c85ecd1 to
1b55bb4
Compare
|
Review feedback is addressed on rebased head 1b55bb4. I regenerated with code-generator v0.62.0 plus pkg #50, ran all Go tests and vet, confirmed deterministic generation and CRD compatibility, and collected all five updated E2E tests with the pinned acktest dependency. I replied to and resolved the addressed threads; the managed-memory ARN reference thread remains open because v0.62.0 cannot derive a Ref name from a nested field named only Arn. The PR description now maps handwritten versus generated files and reflects the narrower upstream E2E scope. When the patch looks reasonable, please add /ok-to-test or run the individual jobs. The verify-code-gen job remains dependent on pkg #50 being merged, released, and consumed by code-generator. |
|
/retest-required |
|
@rdoshi1: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
| properties: | ||
| actorID: | ||
| type: string | ||
| arn: |
There was a problem hiding this comment.
Hmm we do have an open code-generator PR to add nested rename support. Will see if we can get that merged in the near term.
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, rdoshi1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rdoshi1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes [2900](aws-controllers-k8s/community#2900) Releasing changes: * #43
Issue: aws-controllers-k8s/community#2900
Summary
Add generated ACK resources for the Bedrock AgentCore
HarnessandHarnessEndpointAPIs introduced inbedrock-agentcorecontrolSDK v1.47.0.The resources support ACK-managed create, read, update, and delete; asynchronous readiness and terminal-state handling; tag reconciliation; Harness execution-role and HarnessEndpoint-to-Harness references; and status observation for ARN, IDs, versions, failure reasons, timestamps, and the managed AgentRuntime identity.
This PR is ready for review, but final regeneration and
verify-code-gendepend on pkg #50 being merged, released, and consumed by code-generator.Reviewer map
Review the small
pkgPR first. For this PR, the principal handwritten files are:generator.yaml— resource selection, field mappings, references, lifecycle gates, and hook registration.templates/hooks/harness/**— observe the managed AgentRuntime and tags; synchronize tags; construct the SDK's optional-value wrappers for Harness updates.templates/hooks/harnessendpoint/**— observe and synchronize tags.pkg/resource/harness/hooks.goandpkg/resource/harness_endpoint/hooks.go— helpers called by those templates.pkg/resource/harness/hooks_test.goandpkg/resource/harness_endpoint/hooks_test.go— focused unit coverage for handwritten helpers.test/e2e/resources/harness*.yamlandtest/e2e/tests/test_harness*.py— ACK create/read/update/delete, status, references, tags, and terminal-error coverage.The API types, reconcilers, reference resolvers, CRDs, RBAC, Helm output, and registration changes are generated output. They should be verified by regeneration, compilation, tests, and the CRD compatibility check rather than reviewed as independently handwritten code.
Generation
Current output was generated from
code-generatorv0.62.0 with a local module replacement topkgPR #50 and release version v1.12.1:The generation metadata reports
v0.62.0-dirtyonly because of that temporary local replacement; the replacement is not committed here. Once #50 is released and consumed bycode-generator, this branch must be regenerated from the released dependency.Review feedback incorporated
HarnessTool.typeJSON tag.acktest.aws.identity.get_account_id()rather than a custom expected-account fixture.The nested managed-memory field is named only
arnin the service model. Code-generator v0.62.0 cannot derive a*Reffield name from a bare identifier suffix and has no nested-shape rename override, so a Memory reference is not generated in this PR. Direct ARN input remains supported.Intentional first-pass exclusions
additionalParamsand inline-functioninputSchemafields use Smithydocument, which ACK v0.62.0 cannot represent directly.remoteMcp.headersmay contain credentials and is excluded until it can use secret-backed values rather than plain CR fields.Validation on the current head
go vetpass.acktestdependency.HarnessandHarnessEndpointas new.Upstream CI still needs an organization member to run
/ok-to-test(or the individual test commands) after this update.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.