Conversation
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
8 times, most recently
from
August 15, 2026 11:26
eb37946 to
3421c66
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
8 times, most recently
from
August 23, 2026 06:01
4ca3efe to
1f6f2c6
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
7 times, most recently
from
August 31, 2026 03:40
7eaf886 to
0f12dfd
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
6 times, most recently
from
September 5, 2026 18:40
bac6c66 to
1c06bfa
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
from
September 8, 2026 14:47
1c06bfa to
fe7156b
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
8 times, most recently
from
September 16, 2026 13:21
ed59b4a to
f7b92f9
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
3 times, most recently
from
September 20, 2026 06:13
d0d4494 to
1b15170
Compare
tsushanth
force-pushed
the
fix/testfiles-undefined-on-glob-error
branch
from
September 21, 2026 06:04
1b15170 to
12229cb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
globs.findTestsrejects (bad glob config, permission error, IO failure), thecatchblock inApi#runstores the error insetupOrGlobErrorbut leavestestFilesasundefined. The very next statement buildsselectionInsights:This crashes before
setupOrGlobErroris ever re-thrown, so the original error is swallowed and the user sees a confusingTypeErrorinstead.Fix
Use optional chaining so the property access is safe when
testFilesis undefined:Reproduction
Configure
avawith afilesglob that causesfindTeststo throw (e.g., pass an invalid pattern that triggers the internal validation error), or simulate an IO failure inglobs.findTests. The run crashes with:instead of surfacing the underlying glob/config error.