Add text style transfer (#166)#263
Open
swapnull7 wants to merge 21 commits into
Open
Conversation
* initial commit * bug fixes and adjusting conv inputs * separate forward function for Discriminator and Generator and disable Gen training for debugging * remove debugger statement * bug fix * detaching stuff before accumulating * refactor and add component as optional parameter * Add optimizer for and backprop against encoder * Add in README
* initial commit * bug fixes and adjusting conv inputs * separate forward function for Discriminator and Generator and disable Gen training for debugging * remove debugger statement * bug fix * detaching stuff before accumulating * refactor and add component as optional parameter * Add optimizer for and backprop against encoder * Add in README * more fixes to eval mode * create optimizers so that they can be saved * fix typo
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 82.53% 82.48% -0.05%
==========================================
Files 205 206 +1
Lines 15829 15848 +19
==========================================
+ Hits 13064 13072 +8
- Misses 2765 2776 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* initial commit * bug fixes and adjusting conv inputs * separate forward function for Discriminator and Generator and disable Gen training for debugging * remove debugger statement * bug fix * detaching stuff before accumulating * refactor and add component as optional parameter * Add optimizer for and backprop against encoder * Add in README * more fixes to eval mode * create optimizers so that they can be saved * fix typo * linting issues * add type annotation for encoder * fix linting * Isolate AE in training * works after changing the learning rate * remove debugger
Collaborator
|
Please merge |
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
Collaborator
|
You might also want to change the PR title; should reference #166 instead. |
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
| train_op_g.zero_grad() | ||
| step += 1 | ||
|
|
||
| vals_d = model(batch, gamma_, lambda_g_, mode="train", |
Collaborator
There was a problem hiding this comment.
Which dataset do you use here? train_g? It seems that train_d is used in texar-tf. Why does such a difference exist?
Collaborator
Author
There was a problem hiding this comment.
For training, I use the same dataset because it is tricky to switch datasets between steps. And considering the discriminator and generator are trained separately, I've noticed it doesn't really affect the results.
Collaborator
Author
There was a problem hiding this comment.
Removing the 2 iterators and keeping just one train iterator.
Collaborator
There was a problem hiding this comment.
If that is the case, we do not need to have train_d in the iterator (?)
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
gpengzhi
reviewed
Dec 9, 2019
| hparams=config.model['opt'] | ||
| ) | ||
|
|
||
| def _train_epoch(gamma_, lambda_g_, epoch, verbose=True): |
Collaborator
There was a problem hiding this comment.
In texar-tf, both train_d and train_g are used in the _train_epoch, but we only use train_g in this function. Did I miss something important?
* Reviewed changes * linting
* initial commit * linting
swapnull7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial commit
bug fixes and adjusting conv inputs
separate forward function for Discriminator and Generator and disable Gen training for debugging
remove debugger statement
texar bug fix
detaching stuff before accumulating
refactor and add component as optional parameter
Add optimizer for and backprop against encoder
Add in README