chore(EMI-3293): unify order offer summary components#17423
Merged
dariakoko merged 5 commits intoJul 6, 2026
Merged
Conversation
… create Order2OrderSummary
#9092 Bundle Size — 8.96MiB (+0.2%).f4ba87e(current) vs aa73561 main#9083(baseline) Warning Bundle contains 29 duplicate packages – View duplicate packages Bundle metrics
|
| Current #9092 |
Baseline #9083 |
|
|---|---|---|
 Initial JS |
2.92MiB(+0.12%) |
2.91MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
100% |
97.44% |
| Chunks |
112(+0.9%) |
111 |
| Assets |
115(+0.88%) |
114 |
| Modules |
5645(+0.27%) |
5630 |
| Duplicate Modules |
663(+1.07%) |
656 |
| Duplicate Code |
4.95%(+0.2%) |
4.94% |
| Packages |
248 |
248 |
| Duplicate Packages |
28 |
28 |
Bundle size by type 2 changes 2 regressions
| Current #9092 |
Baseline #9083 |
|
|---|---|---|
| JS |
8.73MiB (+0.17%) |
8.71MiB |
| Other |
236.63KiB (+1.06%) |
234.14KiB |
Bundle analysis report Branch daria/EMI-3293/unify-order-offer... Project dashboard
Generated by RelativeCI Documentation Report issue
starsirius
reviewed
Jul 6, 2026
| artwork: Order2OrderSummaryArtwork | ||
| isPricingLoading?: boolean | ||
| /** Extra line rendered within the artwork block, below the list price. */ | ||
| artworkExtraContent?: React.ReactNode |
Member
There was a problem hiding this comment.
#suggestion: might be fine to be explicit and call this limitedTimeOffer? or something.
starsirius
reviewed
Jul 6, 2026
| </Text> | ||
| <Text overflowEllipsis variant="sm" color="mono60" textAlign="left"> | ||
| {[artworkTitle, date].join(", ")} | ||
| </Text> |
Member
There was a problem hiding this comment.
This reminds me that we are missing the gallery's name in the summary (which is displayed in the details page summary). Let's use this opportunity to add it back? I'll see if we created a ticket for it.
Contributor
Author
There was a problem hiding this comment.
Hmmm I actually dont see it in the design for either the order or the counteroffer
I'll catchup with Viv and address in a separate PR if needed
dariakoko
added a commit
that referenced
this pull request
Jul 13, 2026
* feat(EMI-3172): create counteroffer step - offer details (#17386) * feat: add respond to offer component, draft * feat: add price breakdown, adjust text sizes * chore: cleanup * feat: add counter offer amount text input * chore: cleanup * feat: animate the OfferDetails component * feat: collapce the offer component on submit * feat: handle submit * chore: adjust styling * chore: remove mutation as its our of scope, will be done in a different ticket * chore: add tests * fix: fix smoke test (not related to the pr) * chore: address review comments * chore: ui changes * chore: tests * chore * feat(EMI-3292): implement address shipping and payment components (#17400) * feat: refactor address, shipping, payment collapsed states and add them to the order screen * chore: add tests * chore: adjust tests * chore * feat(EMI-3174): create offer history component (#17405) * feat: add order history table * feat: adjust styling * chore: add tests * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * chore: address review comments --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * chore(EMI-3293): unify order offer summary components (#17423) * chore: refactor Order2RespondSummary and Order2ReviewStep components, create Order2OrderSummary * chore: refactor * chore: remane title to header * chore: address review comments * feat: add offer exp component (#17437) * feat(EMI-3288): submit counteroffer step (#17442) * feat: add continue to review offer * feat: add RespondCompletedView state * chore: add a todo comment for edit cta * chore: adjust the copy * chore: cleanup the types * feat: add create counter offer * feat: display gallery offer after discarding buyer counter offer * chore: refactor * chore: pre-fill the counter offer amount on page refresh" * feat: submit counter offer, accept, decline * fix: add hasCurrentCounterofferDraft to ensure correct data is displayed on repeated counter offer * chore: adjust comments * chore: refactor, cleanup * chore(EMI-3282): counteroffer tracking (#17444) * chore: add toggledOfferHistory and clickedCounterOfferOption tracking * chore: add clickedOrderProgression call * refactor: extract select action * fix: merge conflict * chore: add clickedOrderProgression and submittedCounterOffer on submit * feat: add terms and conditions link (#17453) * fix: update total for incomplete offer for history to say N/A (#17466) --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Rachel Quartararo <50849237+rquartararo@users.noreply.github.com> Co-authored-by: Oksana <oksana@artsymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Chore
This PR solves EMI-3293
Description
Extracts the shared order-summary card (artwork row + pricing breakdown + buyer-guarantee message) into a single reusable
Order2OrderSummarycomponent, consumed by bothOrder2ReviewStep(checkout) andOrder2RespondSummary(respond).The components on Respond and Checkout routes have identical structure (TODO: in another PR add missing parts to the component on Respond (offer exp data, Submit cta)