Add time-domain IR render and utility functions#198
Merged
Conversation
Add `build_impulse_response` for time-domain FDN rendering (avoids FFT aliasing), `fade_out` for linear tail attenuation, and `labeled_audio` for marimo A/B listening layouts. Rename `with_decay` to `build_set_decay` for clarity. Update example notebook to use the new functions and simplify audio rendering code.
jeremybbq
approved these changes
Jul 5, 2026
Collaborator
Author
|
@jeremybbq Thanks for checking the PR. Please go ahead with the merge (once the CI passes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
build_impulse_responsefor time-domain FDN rendering (avoids FFT aliasing),fade_outfor linear tail attenuation, andlabeled_audiofor marimo A/B listening layouts. Renamewith_decaytobuild_set_decayfor clarity. Update example notebook to use the new functions and simplify audio rendering code.Summary
Fixes #
Changes
Testing
pytestpasses locallypytest --cov=pyFDN)Checklist
pre-commit run --all-files)HISTORY.rstupdated if this is a user-facing change