Skip to content

Add time-domain IR render and utility functions#198

Merged
jeremybbq merged 3 commits into
mainfrom
fix/flamo_training_example
Jul 5, 2026
Merged

Add time-domain IR render and utility functions#198
jeremybbq merged 3 commits into
mainfrom
fix/flamo_training_example

Conversation

@SebastianJiroSchlecht

Copy link
Copy Markdown
Collaborator

Add build_impulse_response for time-domain FDN rendering (avoids FFT aliasing), fade_out for linear tail attenuation, and labeled_audio for marimo A/B listening layouts. Rename with_decay to build_set_decay for clarity. Update example notebook to use the new functions and simplify audio rendering code.

Summary

Fixes #

Changes

Testing

  • pytest passes locally
  • New tests added for new functionality
  • Coverage not decreased (pytest --cov=pyFDN)

Checklist

  • Pre-commit hooks pass (pre-commit run --all-files)
  • Docstrings updated for any changed public API
  • HISTORY.rst updated if this is a user-facing change

Add `build_impulse_response` for time-domain FDN rendering (avoids FFT aliasing), `fade_out` for linear tail attenuation, and `labeled_audio` for marimo A/B listening layouts. Rename `with_decay` to `build_set_decay` for clarity. Update example notebook to use the new functions and simplify audio rendering code.

@jeremybbq jeremybbq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name suggest.

Comment thread src/pyFDN/translate/dss_to_impz.py Outdated
@SebastianJiroSchlecht

Copy link
Copy Markdown
Collaborator Author

@jeremybbq Thanks for checking the PR. Please go ahead with the merge (once the CI passes)

@jeremybbq jeremybbq merged commit 0ae2ffb into main Jul 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants