Skip to content

Clarify USCC entity categories and validation limits - #515

Open
zbl1998-sdjn wants to merge 1 commit into
arthurdejong:masterfrom
zbl1998-sdjn:codex/clarify-uscc-entity-categories
Open

zbl1998-sdjn wants to merge 1 commit into
arthurdejong:masterfrom
zbl1998-sdjn:codex/clarify-uscc-entity-categories

Conversation

@zbl1998-sdjn

Copy link
Copy Markdown

The USCC module currently lists ownership and investment structures as examples of the second character's entity categories. This can lead readers to infer ownership from a prefix that instead encodes a category within a registering authority.

This documentation-only change lists the categories under authority 9, explains that the category must be read with the authority, and notes a current exception to inferring the present entity type from a retained code. It also makes the validation boundary explicit: formatting and checksum validation do not establish issuance or current registration.

Official references:

Validation:

python -X utf8 -m doctest -o NORMALIZE_WHITESPACE -o IGNORE_EXCEPTION_DETAIL stdnum/cn/uscc.py tests/test_cn_uscc.doctest
git diff --check

Both checks passed. An AST comparison with docstrings removed also confirmed that executable code is unchanged. No validation rules or accepted-number behavior are changed.

Disclosure: this contribution was prepared with AI assistance while maintaining Currawong's USCI educational resources. The proposed corrections rely on the official references above.

Copilot AI lite review requested due to automatic review settings September 23, 2026 20:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Authority 9 terminology remains inconsistent; update the earlier SAIC wording.

Review effort: Lite
Findings: None

What changed in this PR

Documentation-only clarification of USCC entity categories, retained codes, and validation limits.

Changes:

  • Documents authority-9 categories and retained-code exceptions.
  • Adds official references.
  • Clarifies validation scope without changing executable behavior.
File Summary
stdnum/​cn/​uscc.py Updates module and validation documentation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants