BoingIconBar: fix crash on screen reset, menu and prefs save - #1113
Merged
Conversation
GetDTAttrs() writes IPTR-sized (8 byte) values into the passed storage, but LoadBackground() passed pointers to the 4-byte LONG fields of BackgroundData[]. Also harden the surrounding parsing: bound Levels[] writes in ReadPrefs (SUM_LEVELS, two slots reserved for Settings/Quit), restore the IconCounter < SUM_ICON loop guard, bound IT_Labels[100] in SetWindowParameters/IconLabel, and NULL freed bitmaps and clear stale icon flags in ScreenResetCleanup/Reload.
Kalamatee
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDTAttrs() writes IPTR-sized (8 byte) values into the passed storage, but LoadBackground() passed pointers to the 4-byte LONG fields of BackgroundData[].
Also harden the surrounding parsing: bound Levels[] writes in ReadPrefs (SUM_LEVELS, two slots reserved for Settings/Quit), restore the IconCounter < SUM_ICON loop guard, bound IT_Labels[100] in SetWindowParameters/IconLabel, and NULL freed bitmaps and clear stale icon flags in ScreenResetCleanup/Reload.