netprefs posixc - #1102
Merged
Merged
netprefs posixc#1102
Conversation
bsek
force-pushed
the
bsek/netprefs-posixc
branch
3 times, most recently
from
September 1, 2026 20:42
9a88d43 to
f94371c
Compare
Add set MUIA_List_Active to entries + 1 while the new row sits at entries, relying on MUI to clamp. It was also set outside the guard, so with a full list nothing was inserted but the selection moved anyway. The same in all five places: interfaces, tunnels, hosts, networks and shares.
bsek
force-pushed
the
bsek/netprefs-posixc
branch
from
September 1, 2026 20:47
f94371c to
a939cc2
Compare
Kalamatee
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problem with network configuration lost between saves and removes the test button, as it cannot work correctly given how the network preferences program currently works.
A posixc
FILEholds an fd indexing that base's descriptor table, and posixc ispertaskbase, so the handle is meaningless once it crosses into a module. That caused empty files being written on save.