hir: reject nested storage map fields

[g-r-a-n-t]

No description provided.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e937f2ebff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[cburgdorf]

This doesn't feel right to me. Why should the hir even know about StorageMap. Shouldn't this be caught by a bound on V already? It should be impossible to instantiate a StorageMap where V does not satisfy the WordRepr trait.

impl<K: StorageKey, V: WordRepr, const SALT: u256> StorageMap<K, V, SALT>

But maybe what we should do instead is moving the bound from the impl to the struct:

pub struct StorageMap<K: StorageKey, V: WordRepr, const SALT: u256 = _> {}

I believe that would then create a compile error one level earlier when a user attempts to declare an invalid StorageMap rather than at the time they try to instantiate it.

What does @sbillig think?

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61a302fb88

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[g-r-a-n-t]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 89ae4a61ac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".