Skip to content

Fix MacOS write error caused by unflushed buffer#2

Open
jgartrel wants to merge 1 commit into
arduino:nrffrom
jgartrel:nrf
Open

Fix MacOS write error caused by unflushed buffer#2
jgartrel wants to merge 1 commit into
arduino:nrffrom
jgartrel:nrf

Conversation

@jgartrel

Copy link
Copy Markdown

This change is actually a cherry-picked code change from a pull request to shumatech/BOSSA. Special thanks to @kaysievers for this code (see issues: Bossa 1.9.1 occasionally fails mid-download #120 and the subsequent resolution in Pull Request #150)

This change resolved an issue where (I suppose) flash has not been properly erased prior to writing the new code. This results in a verify error and requires code to be re-flashed to the SAMD21.

PosixSerialPort: Call tcdrain() to write serial data

@CLAassistant

CLAassistant commented Aug 17, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jgartrel

Copy link
Copy Markdown
Author

@facchinm, I am hoping that we can create a patch release for this and upload it to the Arduino package repository. What is the process for that?

@jgartrel

Copy link
Copy Markdown
Author

@cmaglie, @per1234 Do you know what the process is for pull requests and patch releases for this repo/project? Could you please point me in the right direction?

@JetForMe

Copy link
Copy Markdown

I had to make this modification locally in order to flash SAM parts. This pull request has been around for ages, it would be nice to get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants