Add tests for StandardHtmlEncodingDetector content-encoding, EncodingResult fields, and markLimit#2917
Open
vasiliy-mikhailov wants to merge 1 commit into
Conversation
…Result fields, and markLimit
Contributor
|
From claude's review: These make sense to me. Thank you for opening this and improving our unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four JUnit 5 tests to
StandardHtmlEncodingDetectorTestcovering the charset-from-content-encoding detection path, fullEncodingResultfield verification (charset, confidence, label, DECLARATIVE result type), the default markLimit (65536), and customsetMarkLimitbehavior including a meta tag placed beyond the configured limit. The tests reuse the existingassertCharset/detectCharsethelpers and exercise previously uncovered branches in the detector.The additions are append-only (no existing test is modified) and pass against the current code.
How this was produced
This PR was generated with an AI-assisted pipeline built around mutation testing (PIT). The pipeline mutates the target class (flipping conditions and changing boundary/edge cases) and runs the existing tests against each mutant. Where a mutant survives (the existing tests do not catch that edge case), it writes a focused test for that case and reruns PIT to confirm the new test actually kills that specific mutant. So every added test is verified to catch a concrete edge case the suite missed before, rather than being speculative or redundant. The change is additive only (no production code modified), and the module builds green under its CI JDK.