Skip to content

fix(TablesPlot): join selected columns with a comma to emit valid Python #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aglinxinyuan merged 2 commits into from
Jul 23, 2026
Merged

fix(TablesPlot): join selected columns with a comma to emit valid Python #6806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab92ab2
fix(TablesPlot): join selected columns with a comma to emit valid Python
kz930 Jul 22, 2026
7aa2c52
style(TablesPlot): wrap long test assertion to satisfy scalafmt
kz930 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...n/scala/org/apache/texera/amber/operator/visualization/tablesChart/TablesPlotOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ class TablesPlotOpDesc extends PythonOperatorDescriptor {
var includedColumns: List[TablesConfig] = List()

private def getAttributes: String =
includedColumns.map(c => pyb"""${c.attributeName}""").mkString("','")
// Join with a plain comma: each column renders to a decode_python_template(...)
// call, so joining with the literal ',' would put a string right after a call
// and produce invalid Python.
includedColumns.map(c => pyb"""${c.attributeName}""").mkString(",")

def manipulateTable(): PythonTemplateBuilder = {
assert(includedColumns.nonEmpty, "Included Columns cannot be empty")
Expand Down
11 changes: 11 additions & 0 deletions ...ala/org/apache/texera/amber/operator/visualization/tablesChart/TablesPlotOpDescSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,15 @@ class TablesPlotOpDescSpec extends AnyFlatSpec with BeforeAndAfter with Matchers
assert(carries(code, "col_two"))
code should include("class TableChartOperator(UDFTableOperator)")
}

it should "join multiple columns with a comma, not the literal ',' (valid Python)" in {
// Each column renders to a decode(...) call, so they must be comma-joined;
// joining with the literal ',' puts a string right after a call (invalid Python).
opDesc.includedColumns = List(column("col_one"), column("col_two"))
val code = opDesc.generatePythonCode()
code should include(
s"self.decode_python_template('${b64("col_one")}'),self.decode_python_template('${b64("col_two")}')"
)
code should not include "')','"
}
}
Loading