Skip to content

fix(deps, frontend): bump @ngneat/until-destroy from 8.1.4 to 10.0.0 in /frontend#6713

Merged
aglinxinyuan merged 3 commits into
mainfrom
dependabot/npm_and_yarn/frontend/ngneat/until-destroy-10.0.0
Jul 22, 2026
Merged

fix(deps, frontend): bump @ngneat/until-destroy from 8.1.4 to 10.0.0 in /frontend#6713
aglinxinyuan merged 3 commits into
mainfrom
dependabot/npm_and_yarn/frontend/ngneat/until-destroy-10.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 21, 2026

Copy link
Copy Markdown
Contributor

Bumps @ngneat/until-destroy from 8.1.4 to 10.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@ngneat/until-destroy](https://github.com/ngneat/until-destroy) from 8.1.4 to 10.0.0.
- [Commits](https://github.com/ngneat/until-destroy/commits)

---
updated-dependencies:
- dependency-name: "@ngneat/until-destroy"
  dependency-version: 10.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 21, 2026
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@Yicong-Huang

Copy link
Copy Markdown
Contributor

ci fails

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend dependency @ngneat/until-destroy to a newer major version, keeping the Angular UI’s RxJS subscription teardown utility aligned with the latest supported Angular/RxJS ecosystem.

Changes:

  • Bump @ngneat/until-destroy from 8.1.4 to 10.0.0 in frontend/package.json.
  • Update frontend/yarn.lock to reflect the new resolved package version, checksums, and peer/dependency metadata.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/package.json Updates @ngneat/until-destroy dependency version to 10.0.0.
frontend/yarn.lock Updates lockfile entries for @ngneat/until-destroy@10.0.0 and related metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aglinxinyuan

Copy link
Copy Markdown
Contributor

ci fails

will fix.

@aglinxinyuan

Copy link
Copy Markdown
Contributor

The only failing check was the frontend binary-license drift check (build / frontendCheck bundled npm packages against per-module LICENSE-binary files). Dependabot bumped @ngneat/until-destroy to 10.0.0 in package.json / yarn.lock but left frontend/LICENSE-binary pinned at @ngneat/until-destroy@8.1.4 — and since it's a direct production dep, that version drift fails the check even in PR mode (--ignore-transitive-version).

Pushed a commit syncing the LICENSE-binary bullet to 10.0.0. Nothing else was needed — the prod build had already passed, so the major 8→10 jump is fine on Angular 21 (v10's peer is just @angular/core >=13), both versions are MIT, and v10's only dependency change is a tslib range that still resolves to the 2.8.1 already listed.

Re-run is green — build / frontend passes on ubuntu/macOS/Windows (prod build + unit + browser tests + license check).

@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Jul 22, 2026
@aglinxinyuan
aglinxinyuan removed this pull request from the merge queue due to a manual request Jul 22, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 55f75a8 Jul 22, 2026
21 checks passed
@aglinxinyuan
aglinxinyuan deleted the dependabot/npm_and_yarn/frontend/ngneat/until-destroy-10.0.0 branch July 22, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants