test(frontend): cover WorkflowUtilService untested helpers#6689
Open
Ma77Ball wants to merge 2 commits into
Open
test(frontend): cover WorkflowUtilService untested helpers#6689Ma77Ball wants to merge 2 commits into
Ma77Ball wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing frontend unit test coverage for WorkflowUtilService helper methods, improving confidence in workflow graph utility behavior without changing production code.
Changes:
- Add unit tests for
updateOperatorVersioncovering port regeneration, port preservation, and unknown-operator error handling. - Add unit tests for
WorkflowUtilService.parseWorkflowInfofor JSON string parsing vs. object passthrough. - Add unit tests for
getNewCommentBoxdefault position and unique ID generation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6688
How was this PR tested?
cd frontend && node --max-old-space-size=8192 ./node_modules/nx/dist/bin/nx.js test gui --watch=false --include=src/app/workspace/service/workflow-graph/util/workflow-util.service.spec.ts, expect the suite passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF