test(frontend): add unit tests for execute-workflow guards#6649
Conversation
Automated Reviewer SuggestionsBased on the
|
There was a problem hiding this comment.
Pull request overview
Adds a new Vitest spec file to cover the execute-workflow type guards and execution-state helper used by the frontend workspace workflow execution flow.
Changes:
- Added unit tests for
isWebPaginationUpdateandisWebDataUpdate(pagination vs snapshot/delta). - Added unit tests for
isNotInExecutionacross terminal/uninitialized vs active execution states.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please address the comments. |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Merged main to trigger coverage report. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6649 +/- ##
=========================================
Coverage 76.27% 76.27%
Complexity 3452 3452
=========================================
Files 1161 1161
Lines 45919 45918 -1
Branches 5100 5099 -1
=========================================
Hits 35025 35025
Misses 9329 9329
+ Partials 1565 1564 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What changes were proposed in this PR?
frontend/src/app/workspace/types/execute-workflow.interface.spec.ts, a new Vitest spec for the execute-workflow type guards, which previously had no dedicated unit tests.Any related issues, documentation, discussions?
Closes: #6648
How was this PR tested?
cd frontend && node --max-old-space-size=8192 ./node_modules/nx/dist/bin/nx.js test gui --watch=false --include=src/app/workspace/types/execute-workflow.interface.spec.ts, expect all 6 tests passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF