Preserve JDBC setter semantics when replaying prepared statement parameters#39161
Open
somiljain2006 wants to merge 2 commits into
Open
Preserve JDBC setter semantics when replaying prepared statement parameters#39161somiljain2006 wants to merge 2 commits into
somiljain2006 wants to merge 2 commits into
Conversation
Contributor
Author
|
@terrymanu Can you review this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37504
Preserve the original JDBC setter semantics during prepared statement replay by tracking the parameter-binding method independently of the logical parameter values. This fixes cases where stream and LOB-based parameters, such as Oracle BLOB values bound via setBlob(InputStream), were previously replayed using setObject(), resulting in driver-specific failures (for example, ORA-17004: invalid column type). Add regression tests covering replay of BLOB, stream, CLOB, typed object, null, and shifted parameter scenarios to ensure the original binding method is preserved during execution.
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.