Remove Oracle ROWNUM from SQLServer unparenthesized functions#39103
Open
thswlsqls wants to merge 1 commit into
Open
Remove Oracle ROWNUM from SQLServer unparenthesized functions#39103thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Member
|
Please resolve conflict first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39100.
Changes proposed in this pull request:
ROWNUM,ROWNUM_andROW_NUMBERfromSQLServerFunctionOption.getUnparenthesizedFunctionNames(); these are Oracle pseudo-columns that SQL Server does not have (ROW_NUMBERalways needs()+OVER).ColumnSegmentBinder.isUnparenthesizedFunction(), which skipped binding for any identifier in it; a real SQL Server column namedROWNUMwas therefore left unbound (wrong output).FunctionOptions only Oracle legitimately keeps these pseudo-columns; SQLServer was an Oracle copy remnant.SQLServerFunctionOptionTestto assert the remaining niladic functions stay and the three Oracle names are gone.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.