[core] Clean up index files on aborted commits#8572
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
FileStoreCommitImpl.abort cleaned newly written data and changelog files but ignored index files carried by data and compact increments. Aborted writes could therefore leave uncommitted index files behind, including files stored at external paths. Delete both sets of new index files through the partition and bucket aware index path factory while preserving deleted index files. Add regression coverage for data and compact increments, external paths, and retained deleted index files. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FileStoreCommitImpl.abortdeleted uncommitted data and changelog files but ignorednewIndexFilesfrom both data and compact increments. Aborted commits could therefore leave index files behind, including files stored at external paths.Clean up both sets of new index files through
IndexFilePathFactories. KeepdeletedIndexFilesuntouched because they still belong to the active snapshot when the commit is aborted.Tests
mvn -pl paimon-core -Pfast-build -DwildcardSuites=none -Dtest=FileStoreCommitTest testmvn -pl paimon-core -DskipTests verify