[fs] Declare serialVersionUID in COSNLoader for Serializable consistency#8555
Open
thswlsqls wants to merge 1 commit into
Open
[fs] Declare serialVersionUID in COSNLoader for Serializable consistency#8555thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
FileIOLoader is @public and extends Serializable. Among the loaders using the PluginFileIO pattern (OBS/OSS/S3/GS/Azure/COSN), COSNLoader is the only one that declares serialVersionUID on its inner PluginFileIO but not on the outer loader class. Add it to align with the other five and pin the serialization UID instead of relying on the compiler-computed one. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FileIOLoaderis@Publicandextends Serializable, so its implementations are serialized.PluginFileIOpattern (OBSLoader,OSSLoader,S3Loader,GSLoader,AzureLoader,COSNLoader),COSNLoaderis the only one that declaresserialVersionUIDon its innerPluginFileIObut omits it on the outer loader class.1Linstead of relying on the compiler-computed value, aligningCOSNLoaderwith the other five loaders.Tests
serialVersionUIDwithout dedicated tests; the thin loader modules have nosrc/test).mvn -pl paimon-filesystems/paimon-cosn -DfailIfNoTests=false clean installpassed (spotless / checkstyle / rat / enforcer) on JDK 11.