[global-index] Fix full-text range selection and scalar-filter coverage for multi-field indexes#8547
Open
CrownChu wants to merge 3 commits into
Open
[global-index] Fix full-text range selection and scalar-filter coverage for multi-field indexes#8547CrownChu wants to merge 3 commits into
CrownChu wants to merge 3 commits into
Conversation
970083e to
b5ecfec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A global index may contain one primary field and multiple extra fields. However, the current scan paths assume that:
These assumptions prevent multi-field indexes from serving full-text and scalar queries correctly. They may also cause indexed row ranges to be skipped when different index definitions cover different ranges of the same column.
This PR makes the generic global-index scan and read paths multi-field aware:
indexFieldIdandextraFieldIds.(column, row range).IS NOT NULLpredicates only when another predicate on the same field is null-rejecting, preserving the semantics of expressions such as:field IS NULL AND field IS NOT NULL.The changes are backend-independent and do not introduce dependencies on any specific global-index implementation.
Tests
GlobalIndexEvaluatorTest: 19 tests passed.FullTextSearchBuilderTestcases: 4 tests passed.