feat: support rowkind.field write semantics#507
Open
Pandas886 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #502
I ran into the current fail-loud path when trying to write CDC-style rows with a user op column (
rowkind.field). Java already supports this, and the Rust option is parsed but writing still rejects it. This PR wires up the write path for deduplicate PK tables.Brief change log
RowKindparsing (+I/-U/+U/-D, case-insensitive)RowKindGeneratorto map a STRING column onto internal_VALUE_KINDTableWriteenrich step: convert row kinds, optionally drop retracts viaignore-delete/ignore-update-before_VALUE_KINDwhenrowkind.fieldis set (fail loud, no silent override)I deliberately left other merge engines alone — they still get a clear validation error if someone sets
rowkind.fieldthere.Tests
Locally:
All green on my machine.
API and Format
RowKind, plus the existingrowkind.fieldoption now actually works on write_VALUE_KIND)Documentation
No user-facing docs update in this PR. Happy to add a short note to the write docs if reviewers want it.
Notes
This is independent of the incremental-read PR stack I also opened. Review can land in either order.