[OPENJPA-2958] Add ImplHelper.registerUnenhancedInstance() - #170
Merged
Conversation
BrokerImpl reached into the public mutable ImplHelper._unenhancedInstanceMap to register the persistence capable instance of an unenhanced one. Add a method for it and route all three write sites through it, so the registry is no longer written to from outside the class that owns it. Behaviour is unchanged: the method is the same overwriting put. The field is deprecated to point callers at the method. It stays public: its type is a reference type, so it is never inlined into callers, and making it private would turn into a NoSuchFieldError at runtime for anything compiled against 4.1.x rather than a compile error on upgrade. Making it private belongs in a major release.
cristof
approved these changes
Aug 29, 2026
solomax
approved these changes
Aug 31, 2026
Review feedback: 4.2.0 already removes public API, so keeping the field public for compatibility was not worth it. Nothing outside ImplHelper reads or writes it any more. Package private rather than private so that the unit test, which lives in the same package, can still read a registration back; there is no public read path for it, since toPersistenceCapable() rejects a non manageable instance before it reaches the map.
solomax
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrokerImplreached into the public mutableImplHelper._unenhancedInstanceMapto register the persistence-capable instance of an unenhanced one. This adds a method for it and routes all three write sites through it, so the registry is no longer written to from outside the class that owns it. Behaviour is unchanged — the method is the same overwriting put.The field itself is now package private. Nothing outside
ImplHelperreads or writes it any more, and 4.2.0 already removes public API elsewhere, so keeping it public for compatibility was not worth it. Package private rather than private so the unit test, which lives in the same package, can still read a registration back: there is no public read path, sincetoPersistenceCapable()rejects a non-manageable instance before it reaches the map.