OAK-12299 : precompute elementCount and currentWeight in PersistentDiskCache#3004
Open
nfsantos wants to merge 3 commits into
Open
OAK-12299 : precompute elementCount and currentWeight in PersistentDiskCache#3004nfsantos wants to merge 3 commits into
nfsantos wants to merge 3 commits into
Conversation
…skCache Track cache size and element count incrementally in AtomicLong fields instead of recomputing them on every stats read via directory.listFiles() and FileUtils.sizeOfDirectory(), which walked the whole cache directory. Counters are seeded from the on-disk state at startup.
joerghoh
approved these changes
Jul 6, 2026
joerghoh
left a comment
joerghoh
left a comment
Contributor
There was a problem hiding this comment.
looks good, just a minor nit in the tests
| } | ||
|
|
||
| // One temp file (.part) that must NOT be counted | ||
| File temp = new File(cacheFolder, UUID.randomUUID().toString() + System.nanoTime() + ".part"); |
Contributor
There was a problem hiding this comment.
can you reuse the constant TEMP_FILE_SUFFIX in PersistentDiskCache?
reschke
reviewed
Jul 6, 2026
reschke
left a comment
reschke
left a comment
Contributor
There was a problem hiding this comment.
Would be nice to park this until after 2.4.0.
Contributor
Author
I'm neutral on when to merge this. But maybe @joerghoh can comment on whether this change is something that would be useful to get in quickly or if it can wait. I guess this can reduce by a noticeable margin how long it takes to collect metrics from the cache. BTW, this patch is already live in our Oak fork, so it has been running in production for a couple of months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track cache size and element count incrementally in AtomicLong fields instead of recomputing them on every stats read via
directory.listFiles()andFileUtils.sizeOfDirectory(), which walked the whole cache directory. Counters are seeded from the on-disk state at startup.