[fix](cloud) avoid false tablet diagnosis alarms in cloud mode (#60805)#63751
Open
deardeng wants to merge 1 commit into
Open
[fix](cloud) avoid false tablet diagnosis alarms in cloud mode (#60805)#63751deardeng wants to merge 1 commit into
deardeng wants to merge 1 commit into
Conversation
…e#60805) Problem SHOW TABLET DIAGNOSIS reports local-storage style errors in cloud (storage-compute separated) deployments. In cloud mode, replica version in FE is not a reliable per-backend data freshness signal, and backend disk pressure does not directly represent object-storage write availability. Root cause Diagnoser applied the same checks for both local and cloud modes: - ReplicaBackendStatus always evaluated be.diskExceedLimit() - ReplicaVersionStatus always required replica.version == partition visible version (and checked lastFailedVersion) These checks are valid for local replicas but can produce false positives in cloud mode. Change - Added cloud-mode guard via Config.isCloudMode() in Diagnoser. - In cloud mode, skip disk-exceed-limit check when building ReplicaBackendStatus. - In cloud mode, skip replica-version equality and last-failed-version checks when building ReplicaVersionStatus.
Collaborator
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #60805
Problem
SHOW TABLET DIAGNOSIS reports local-storage style errors in cloud (storage-compute separated) deployments. In cloud mode, replica version in FE is not a reliable per-backend data freshness signal, and backend disk pressure does not directly represent object-storage write availability.
Root cause
Diagnoser applied the same checks for both local and cloud modes:
ReplicaBackendStatus always evaluated be.diskExceedLimit()
ReplicaVersionStatus always required replica.version == partition visible version (and checked lastFailedVersion)
These checks are valid for local replicas but can produce false positives in cloud mode.
Change
Added cloud-mode guard via Config.isCloudMode() in Diagnoser.
In cloud mode, skip disk-exceed-limit check when building ReplicaBackendStatus.
In cloud mode, skip replica-version equality and last-failed-version checks when building ReplicaVersionStatus.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)