Skip to content

[fix](cloud) avoid false tablet diagnosis alarms in cloud mode (#60805)#63751

Open
deardeng wants to merge 1 commit into
apache:branch-4.0from
deardeng:pick-60805-to-40
Open

[fix](cloud) avoid false tablet diagnosis alarms in cloud mode (#60805)#63751
deardeng wants to merge 1 commit into
apache:branch-4.0from
deardeng:pick-60805-to-40

Conversation

@deardeng
Copy link
Copy Markdown
Collaborator

pick from #60805
Problem

SHOW TABLET DIAGNOSIS reports local-storage style errors in cloud (storage-compute separated) deployments. In cloud mode, replica version in FE is not a reliable per-backend data freshness signal, and backend disk pressure does not directly represent object-storage write availability.

Root cause

Diagnoser applied the same checks for both local and cloud modes:

  • ReplicaBackendStatus always evaluated be.diskExceedLimit()

  • ReplicaVersionStatus always required replica.version == partition visible version (and checked lastFailedVersion)

These checks are valid for local replicas but can produce false positives in cloud mode.

Change

  • Added cloud-mode guard via Config.isCloudMode() in Diagnoser.

  • In cloud mode, skip disk-exceed-limit check when building ReplicaBackendStatus.

  • In cloud mode, skip replica-version equality and last-failed-version checks when building ReplicaVersionStatus.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…e#60805)

Problem

SHOW TABLET DIAGNOSIS reports local-storage style errors in cloud
(storage-compute separated) deployments. In cloud mode, replica version
in FE is not a reliable per-backend data freshness signal, and backend
disk pressure does not directly represent object-storage write
availability.

Root cause

Diagnoser applied the same checks for both local and cloud modes:

- ReplicaBackendStatus always evaluated be.diskExceedLimit()

- ReplicaVersionStatus always required replica.version == partition
visible version (and checked lastFailedVersion)

These checks are valid for local replicas but can produce false
positives in cloud mode.

Change

- Added cloud-mode guard via Config.isCloudMode() in Diagnoser.

- In cloud mode, skip disk-exceed-limit check when building
ReplicaBackendStatus.

- In cloud mode, skip replica-version equality and last-failed-version
checks when building ReplicaVersionStatus.
@deardeng
Copy link
Copy Markdown
Collaborator Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 60.00% (6/10) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants