refactor: use Arrow cast for decimal rescale check - #5444
Closed
peterxcli wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5094.
Rationale for this change
DecimalRescaleCheckOverflowduplicates Arrow's Decimal128 rescale, HALF_UP rounding, and precision validation. Delegating the fused operation to Arrow removes the sentinel and follow-up null-masking pass while keeping Spark-compatible legacy and ANSI behavior.What changes are included in this PR?
ColumnarValue::cast_towith DataFusion's default cast options for the common one-pass decimal rescale path.NUMERIC_VALUE_OUT_OF_RANGEerrors, SQL query context, scalar inputs, and scale deltas outside Arrow's Decimal128 power table.DecimalExpressionSuitecases and add boundary coverage for rounding, overflow, null propagation, and extreme scale changes.How are these changes tested?
cargo test --manifest-path native/Cargo.toml -p datafusion-comet-spark-expr(647 unit tests and 5 integration tests)cargo test --manifest-path native/Cargo.toml -p datafusion-comet fused_decimal_overflow_keeps_query_contextcargo clippy --manifest-path native/Cargo.toml -p datafusion-comet-spark-expr -p datafusion-comet --all-targets -- -D warningscargo fmt --manifest-path native/Cargo.toml --all -- --check