Skip to content

fix: use current shuffle config in aggregate test - #5439

Merged
sunchao merged 1 commit into
apache:mainfrom
peterxcli:fix/comet-aggregate-suite-shuffle-config
Aug 23, 2026
Merged

fix: use current shuffle config in aggregate test#5439
sunchao merged 1 commit into
apache:mainfrom
peterxcli:fix/comet-aggregate-suite-shuffle-config

Conversation

@peterxcli

Copy link
Copy Markdown
Member

Which issue does this PR close?

Follow-up to #5055.

Rationale for this change

PR #5055 added an aggregate test using the removed COMET_EXEC_SHUFFLE_ENABLED constant. Current main therefore fails the Spark 3.4 Scalafix build while compiling test sources.

What changes are included in this PR?

Use the current COMET_SHUFFLE_ENABLED config entry, matching the rest of CometAggregateSuite and CometConf.

How are these changes tested?

The previously failing command now completes successfully:

./mvnw -B package -DskipTests scalafix:scalafix -Dscalafix.mode=CHECK -Psemanticdb -Pspark-3.4 -Pscala-2.12

@peterxcli

Copy link
Copy Markdown
Member Author

cc @sunchao @andygrove

@sunchao
sunchao merged commit e975f13 into apache:main Aug 23, 2026
101 of 102 checks passed
@peterxcli
peterxcli deleted the fix/comet-aggregate-suite-shuffle-config branch August 24, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants