fix: distinguish reflection failure from absent accessor in IcebergReflection - #5412
Open
unikdahal wants to merge 1 commit into
Open
fix: distinguish reflection failure from absent accessor in IcebergReflection#5412unikdahal wants to merge 1 commit into
unikdahal wants to merge 1 commit into
Conversation
Author
|
@mbutrovich @andygrove this implements the option B you both landed on in #5258, PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5258.
Rationale for this change
extractFileLocation,getFileFormat,getEqualityFieldIdscollapsed "accessor notdeclared" and "accessor threw" into the same
None/empty. Live bug:CometScanRulereads an empty
getEqualityFieldIdsas "position delete" and goes native, even whenthe empty was actually a swallowed failure.
What changes are included in this PR?
Option/empty now means "not declared" only; genuine invoke failures propagate.Matches
findMethod's existing contract, per review comment on the issue. No callerchanges needed at
CometScanRule-- its existing outer catch just starts firingcorrectly.
How are these changes tested?
New
IcebergReflectionSuitecases proving failures propagate instead of collapsing.