Skip to content

feat(android,ios): Support for passing in request headers#115

Open
sanketmehta7 wants to merge 4 commits into
apache:masterfrom
sanketmehta7:master
Open

feat(android,ios): Support for passing in request headers#115
sanketmehta7 wants to merge 4 commits into
apache:masterfrom
sanketmehta7:master

Conversation

@sanketmehta7

Copy link
Copy Markdown

Support for passing request headers only for android.
User need to pass comma separated headers, with their key, values separated by :
Eg: cordova.InAppBrowser.open("http://apache.org", "_self", 'location=no','custom-h1:asd,h1:xyz');

@TakkuzOld

Copy link
Copy Markdown

This would be really useful, mostly on WP8, (if it will be possible) where file-transfer fails.

@olivercs

olivercs commented Aug 8, 2016

Copy link
Copy Markdown

Very useful when you have to send a token or Authorization header to access to a resource.

@kodeine

kodeine commented Nov 10, 2016

Copy link
Copy Markdown

@sanketmehta7 can you please fix the conflicts so this can be merged?

@ghost

ghost commented Dec 13, 2016

Copy link
Copy Markdown

Would there be any chance for ios as well?

@mrtnjln

mrtnjln commented Jan 17, 2017

Copy link
Copy Markdown

Any news on this ?
I can't build on Xcode (missing .h declaration for navigateToNew method).

@ramses80

Copy link
Copy Markdown

hellow.julymartin.can.you.herme.or.not

@infil00p

Copy link
Copy Markdown
Member

This is an API change and should be discussed on the list, or at the very least have a JIRA issue attached to it. Also, the conflicts are definitely going to prevent this from getting merged as-is.

@rdksgit

rdksgit commented Jun 13, 2018

Copy link
Copy Markdown

Does this work with ios

@daveshirman

Copy link
Copy Markdown

@rdksgit Nope, using this forked version causes the iOS build code 65. So basically unless the developer can fix the reason why it causes the build to fail, this plugin is not production ready.

Note: you won't see the build error on Android build, just iOS.

@sanketmehta7 Thanks for this plugin very much. Is there any chance that you will be able to sort the build (causing issue Error 65) any time soon please?

Feedback would be greatly appreciated, thank you.

@janpio

janpio commented Sep 16, 2018

Copy link
Copy Markdown
Member

Hey @sanketmehta7 , there seems to be a merge conflict now. Could you maybe fix this? Thanks.

@janpio janpio changed the title Support for passing request headers for android feat(android): Support for passing in request headers Jul 3, 2019
@janpio janpio changed the title feat(android): Support for passing in request headers feat(android,ios): Support for passing in request headers Jul 3, 2019

@janpio janpio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard conflicts, which is not a big surprise after so long.
As the feature itself still looks interesting, this should probably be resurrected as a new PR.

@Aiuspaktyn

Copy link
Copy Markdown

Any news about this PR?

@sanketmehta7

Copy link
Copy Markdown
Author

will try to create new PR from latest code

@kasp1

kasp1 commented Mar 11, 2021

Copy link
Copy Markdown

In the meantime, if anyone needs to access an HTTP auth protected site/resource, you can include the creds in the URL, e.g.:

https://username:password@host.name/...

It's got me over this issue for now, so it could help someone else as well.

@iantearle

Copy link
Copy Markdown

will try to create new PR from latest code

Did you have any luck with this?

@sawaca96

Copy link
Copy Markdown

Any update?

@lubbo

lubbo commented Sep 26, 2023

Copy link
Copy Markdown

Hard conflicts, which is not a big surprise after so long.
As the feature itself still looks interesting, this should probably be resurrected as a new PR.

@janpio What about #1024 ?
I'm not changing API but using the options with json and base64 encoding for headers and cookies as well.
Let me know.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.