Skip to content

Make sure session creation happens before starting agent#38477

Open
damccorm wants to merge 4 commits into
masterfrom
users/damccorm/awaitSessionCreation
Open

Make sure session creation happens before starting agent#38477
damccorm wants to merge 4 commits into
masterfrom
users/damccorm/awaitSessionCreation

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

There is currently a race condition because we don't await session creation correctly. This causes SessionNotFound issues in some cases


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Copy Markdown
Contributor Author

Confirmed that ml tests still pass locally, current failures are due to the workflow being permared https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_ML.yml?page=2&query=branch%3Amaster

@damccorm damccorm marked this pull request as ready for review May 14, 2026 14:37
@damccorm
Copy link
Copy Markdown
Contributor Author

R: @jrmccluskey (small fix to #37917)

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant