chore: fix builds after conda-forge upgrade - #4689
Open
lidavidm wants to merge 8 commits into
Open
Conversation
It seems conda-forge compilers no longer includes binutils?
lidavidm
marked this pull request as ready for review
August 14, 2026 05:15
Member
Author
|
Locally, this seems to work. |
lidavidm
commented
Aug 14, 2026
| --file ci/conda_env_cpp.txt \ | ||
| --file ci/conda_env_python.txt | ||
| --file ci/conda_env_python.txt \ | ||
| ${{ (runner.os == 'Linux' && 'gcc gxx') || 'clang clangxx "clang-21>=21.1.8"' }} |
Member
Author
There was a problem hiding this comment.
I think this is necessary as otherwise it seems to pick up system cc. But I think the version pin isn't necessary since I removed the libxml2 pin below (which somehow influenced the clang version)
Member
Author
|
The final CI failure means we need to upgrade nanoarrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems conda-forge compilers no longer includes binutils?
conda-forge/compilers-feedstock#78
Failing: https://github.com/apache/arrow-adbc/actions/runs/31757255697/job/94635721116
Passing: https://github.com/apache/arrow-adbc/actions/runs/31654305086/job/94305293985
Closes #4690.