Remove Custom...Server.java classes and replace with Thrift implementation - #6454
Open
Amemeda wants to merge 16 commits into
Open
Remove Custom...Server.java classes and replace with Thrift implementation#6454Amemeda wants to merge 16 commits into
Amemeda wants to merge 16 commits into
Conversation
Amemeda
marked this pull request as ready for review
June 30, 2026 16:03
Contributor
Author
dlmarion
reviewed
Jul 9, 2026
dlmarion
reviewed
Jul 10, 2026
ctubbsii
reviewed
Jul 24, 2026
ctubbsii
left a comment
Member
There was a problem hiding this comment.
I need to check this over again to see if there's anything else, but I did find one thing.
Contributor
|
I think |
dlmarion
approved these changes
Jul 29, 2026
ctubbsii
requested changes
Aug 1, 2026
ctubbsii
left a comment
Member
There was a problem hiding this comment.
Looks good, but a few thoughts:
- Still some room to clean up boilerplate to reduce redundant setting of the event handler
- I am very wary of relying on the ThreadLocal. I think code that uses the clientAddress should really make sure to grab it right after the initial RPC connection, and pass it along, so that way they know they are grabbing it from the same thread in which it is set; I skimmed all the times the thread local was accessed, and it seemed like it was only being done in the same thread where it is set, but it's hard to verify because in many places, we only use it when an exception occurs.
- Since the enum string was altered, backwards compatibility needs to be fixed if a user explicitly set "custom_hs_ha" in their config instead of relying on the defaults
- I didn't actually run it to verify that the trace log messages or the audit logs were recording the client address. Please check that and verify that it is still logging correctly.
Of these, 3 and 4 are the most important. 1 and 2 could be done as a follow on. Of those, 1 is the more important one for me, since its smaller and would simplify the utility class a bit, making the code slightly more maintainable (which is important for future work).
Contributor
Author
ctubbsii
reviewed
Aug 6, 2026
dlmarion
reviewed
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Investigated relevance of a few custom tserver related java classes, deleted them, reworked their implementation with thrift methods
Result:
setServerEventHandler(new ThriftServerEventHandler());to applicable tserversThriftServerType.CUSTOM_HS_HA, updated usages