Encrypt bootstrap SSM parameter to survive org re-encryption policies#6857
Open
HeathHopkins wants to merge 1 commit intoanomalyco:devfrom
Open
Encrypt bootstrap SSM parameter to survive org re-encryption policies#6857HeathHopkins wants to merge 1 commit intoanomalyco:devfrom
HeathHopkins wants to merge 1 commit intoanomalyco:devfrom
Conversation
Change the /sst/bootstrap SSM parameter from String to SecureString and read it with WithDecryption: true. This prevents breakage when an AWS organization policy automatically re-encrypts unencrypted SSM parameters. Backward-compatible: WithDecryption is a no-op for existing String parameters, and PutParameter with Overwrite allows upgrading String to SecureString on the next bootstrap version bump. Matches the pattern already used by the passphrase parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6856
Summary
/sst/bootstrapSSM parameter fromStringtoSecureStringand read it withWithDecryption: trueMotivation
Some AWS organizations enforce policies that automatically convert unencrypted SSM parameters to
SecureString. Once this happens, the bootstrap parameter becomes unreadable because SST callsGetParameterwithWithDecryption: false, which returns encrypted ciphertext instead of the plaintext JSON.Changes
Two changes in
pkg/project/provider/aws.goinsideBootstrap():GetParameterfor/sst/bootstrap:WithDecryptionchanged fromfalsetotruePutParameterfor/sst/bootstrap:Typechanged fromParameterTypeStringtoParameterTypeSecureStringBackward Compatibility
This is safe for existing deployments with unencrypted
Stringbootstrap parameters:WithDecryption"is ignored forStringandStringListparameter types." Existing unencrypted parameters are returned identically.PutParameterwithOverwrite: trueallows changing the type fromStringtoSecureStringseamlessly.