fix(sidebar): fix logic and missleading message #26469#26470
Open
Polo123456789 wants to merge 1 commit intoanomalyco:devfrom
Open
fix(sidebar): fix logic and missleading message #26469#26470Polo123456789 wants to merge 1 commit intoanomalyco:devfrom
Polo123456789 wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
contributor
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Collaborator
|
good simple pr, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #26469
Type of change
What does this PR do?
It just updated the logic check, from using false as disabled to using undefined as disabled. And updates the message because it is now the default.
How did you verify your code works?
I ran it locally and verified that the message is updated on a clean (no config) environment.
Screenshots / recordings
Checklist
If you do not follow this template your PR will be automatically rejected.