fix(opencode): make bash tool description parameter optional#26420
Open
RheagalFire wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): make bash tool description parameter optional#26420RheagalFire wants to merge 1 commit intoanomalyco:devfrom
RheagalFire wants to merge 1 commit intoanomalyco:devfrom
Conversation
f7c4781 to
36b4845
Compare
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potentially related PR: PR #13823: fix: sanitize tool schemas for strict JSON Schema validators (#13737) This PR appears to be directly related to the current PR (#26420). Both address the issue of invalid tool schemas that fail strict JSON Schema validators. PR #13823 handles schema sanitization for validators that reject schemas with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13618
Type of change
What does this PR do?
Claude and other providers reject tool schemas that have
propertiesbut norequiredfield with:JSON schema is invalid. It must match JSON Schema draft 2020-12.Plugin tools like
session_listgenerate schemas withpropertiesbut norequired. The existing code only handles this for Google/Gemini (filteringrequiredin the Gemini sanitizer). Other providers getthe raw schema and reject it.
The fix adds a recursive
ensureRequiredpass intransform.tsthat setsrequired: []on any object schema missing it. Runs before any provider-specific sanitizers so all providers benefit.How did you verify your code works?
bun turbo typecheckpasses (12/12 packages)Checklist