fix(opencode): make bash tool description parameter optional#26419
Open
RheagalFire wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): make bash tool description parameter optional#26419RheagalFire wants to merge 2 commits intoanomalyco:devfrom
RheagalFire wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Related PR:
|
8769f7b to
d7b5878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20669
Type of change
What does this PR do?
The bash tool's
descriptionparameter is defined asSchema.String(required) inprompt.ts. Local OpenAI-compatible backends like llama.cpp, LM Studio, and LiteLLM sometimes omit this field when calling thetool. This causes validation to fail with
expected string, received undefined, killing the agent loop.The fix:
prompt.ts: ChangedSchema.StringtoSchema.optional(Schema.String)for thedescriptionparametershell.ts: Added?? ""fallback whereparams.descriptionis passed downstream, since the type is nowstring | undefinedThe prompt text already says "it is very helpful if you write a clear, concise description" which implies optional behavior. This aligns the schema with that intent.
How did you verify your code works?
bun turbo typecheckpasses (12/12 packages)Checklist