fix(app): hydrate session before prompt submit#26414
Open
jeremyakers wants to merge 1 commit intoanomalyco:devfrom
Open
fix(app): hydrate session before prompt submit#26414jeremyakers wants to merge 1 commit intoanomalyco:devfrom
jeremyakers wants to merge 1 commit intoanomalyco:devfrom
Conversation
Fixes anomalyco#23903. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23903
Type of change
What does this PR do?
Submitting on an existing session route used local
input.info()immediately. After a refresh or restart, that local session list can still be hydrating even though the backend session exists, so prompt submit could fail before sending.This waits for
sync.session.sync(params.id)when an existing route is missing local session info, then re-readsinput.info(). If sync fails or the session is still missing, it still fails instead of creating fake session state. The tests cover both the hydrated valid-session path and the genuinely missing-session path.How did you verify your code works?
PATH="/home/jeremy/.bun/bin:$PATH" /home/jeremy/.bun/bin/bun run test:unit -- src/components/prompt-input/submit.test.tsfrompackages/app(330 pass, 0 fail)/home/jeremy/.bun/bin/bun typecheckfrompackages/appPATH="/home/jeremy/.bun/bin:$PATH" /home/jeremy/.bun/bin/bun run buildfrompackages/appGIT_MASTER=1 git diff --check origin/dev...HEADbun turbo typecheck(14/14 packages passed)Screenshots / recordings
Not included; this is a prompt submit behavior fix with no visual UI change.
Checklist