refactor: extract activity animationEnabled/animationDisabled into :common:android#21182
Merged
Merged
Conversation
7b452aa to
ed0375d
Compare
ed0375d to
a4ee650
Compare
a4ee650 to
255e91e
Compare
255e91e to
0e4c73f
Compare
5 tasks
6349c04 to
da271b9
Compare
da271b9 to
ce9b61a
Compare
AnkiActivity needs to be moved to common for multimodule prep. Therefore AnimUtils needs to move Therefore `PrefsRepository(context).removeAppAnimations` This is the first step: making 'PrefsRepository' an 'AnimationPreferences' Part of 20737 Assisted-by: Claude Opus 4.8
It was decided that Preferences are per-profile, so this preference needs to be profile-aware. ---- AnkiActivity needs to be moved to common for multimodule prep. Therefore AnimUtils needs to move This is the second step: exposing 'AnimationPreferences' in a profile-safe manner and moving AnimUtils. Part of 20737 Assisted-by: Claude Opus 4.8
This commit was deferred so the previous commit was detected as a rename Assisted-by: Claude Opus 4.8
AnkiActivity needs to be moved to common as prep for multi-modules. This is the final step of extracting animations from AnkiActivity: moving them to extension methods on FragmentActivity. Part of 20737 Assisted-by: Claude Opus 4.8
ce9b61a to
8434e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.8 - all
Purpose / Description
Note: this is also an initial pattern for Profile-aware Preferences in a multimodule situation
Note: This also sets a pattern for handling singletons in
EmptyApplicationAnkiActivityneeds to be moved tocommonas prep for multi-modules: it needs to be below feature modules which use it.I'm focusing on
AnkiActivitydue to:widgetscontaining:This PR extracts 'animations' from
AnkiActivity: moving them to extension methods onFragmentActivity.Fixes
Approach
See commits: iterative extractions
How Has This Been Tested?
Checklist