build: add package metadata to @angular/ssr package.json#33195
Merged
Conversation
Unlike ng_package doesn't add these fields.
angular-robot
Bot
added
the
area: build & ci
alan-agius4
added
target: rc
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package.json for the @angular/ssr package by adding metadata fields including repository, author, license, and issue tracker information. The reviewer suggested adding a directory property to the repository object to correctly link to the package's source within the monorepo.
Comment on lines
+11
to
+14
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/angular/angular-cli.git" | ||
| }, |
There was a problem hiding this comment.
In a monorepo, it is recommended to include the directory property within the repository object for sub-packages. This allows tools and registries (like npmjs.com) to correctly link to the source code of the specific package.
Suggested change
| "repository": { | |
| "type": "git", | |
| "url": "git+https://github.com/angular/angular-cli.git" | |
| }, | |
| "repository": { | |
| "type": "git", | |
| "url": "git+https://github.com/angular/angular-cli.git", | |
| "directory": "packages/angular/ssr" | |
| }, |
dgp1130
approved these changes
May 13, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike ng_package doesn't add these fields.