build: upgrade pnpm to v11 and migrate pnpm configuration to pnpm-wor…#33168
Open
alan-agius4 wants to merge 1 commit into
Open
build: upgrade pnpm to v11 and migrate pnpm configuration to pnpm-wor…#33168alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…kspace.yaml Update to latest pnpm
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades pnpm to version 11.1.0 and migrates various configuration settings—including hoisting, peer dependency handling, and package overrides—from .npmrc and package.json into pnpm-workspace.yaml. A significant concern was raised regarding the removal of the .npmrc file and its reference in MODULE.bazel. The reviewer noted that aspect_rules_js may not yet support reading these configuration keys from pnpm-workspace.yaml, which could lead to inconsistencies between local pnpm installations and Bazel builds.
alan-agius4
added
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.